Skip to content

test: cover ComplianceRegistry.all() and stop excluding index.ts from coverage (fixes #45)#58

Open
hanu-14 wants to merge 4 commits into
alphacrack:mainfrom
hanu-14:test/compliance-registry-and-index-coverage
Open

test: cover ComplianceRegistry.all() and stop excluding index.ts from coverage (fixes #45)#58
hanu-14 wants to merge 4 commits into
alphacrack:mainfrom
hanu-14:test/compliance-registry-and-index-coverage

Conversation

@hanu-14

@hanu-14 hanu-14 commented Jul 19, 2026

Copy link
Copy Markdown

Adds tests asserting ComplianceRegistry.all() returns in-sync S3 reports with valid controls, and removes the index.ts exclusion from jest coverage collection (now 100% line coverage).

@hanu-14
hanu-14 requested a review from alphacrack as a code owner July 19, 2026 16:46
@github-actions github-actions Bot added s3 Relates to the S3 SecureBucket resource core Relates to core (security levels, compliance) tests Test coverage and test infrastructure labels Jul 19, 2026
@alphacrack alphacrack mentioned this pull request Jul 21, 2026
Open
alphacrack
alphacrack approved these changes Jul 21, 2026
View reviewed changes

@alphacrack alphacrack left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the strongest PR of the set — the toContainEqual(S3BucketCompliance.report()) sync assertion is exactly the drift-catcher #45 asked for, the per-entry shape checks will hold future resources to the same bar, and removing the !src/**/index.ts coverage exclusion closes the blind spot (note it also un-hides the resources/*/index.ts barrels, so thanks for confirming the suite still passes with coverage collected there).

Merges last since it's stacked on #56/#57.

@alphacrack

alphacrack commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Re-checked against the new main: MERGEABLE/CLEAN — including jest.config.js, which today's merges didn't touch. Approval stands.

One sequencing note: this branch is stacked above #57, so its diff currently carries #57's fields.test.ts as-is. Preferred path is #57's fix lands first and the stack merges in order. If #57 stalls, merging this PR would bring in #57's tests without the fallback cases — acceptable, but then #57 gets closed as superseded and the fallback cases become a small follow-up.

@hanu-14

hanu-14 commented Jul 21, 2026

Copy link
Copy Markdown
Author

Thanks for the review and approval, alphacrack! I’ll rebase this branch on top of #57 to ensure the diff reflects the latest changes, and I’ll update the PR description to clarify the sequencing. If #57 stalls, I’ll merge this PR and address the fallback cases in a follow-up.

@hanu-14 hanu-14 closed this Jul 22, 2026
@hanu-14 hanu-14 reopened this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alphacrack alphacrack alphacrack approved these changes

Assignees

No one assigned

Labels

core Relates to core (security levels, compliance) s3 Relates to the S3 SecureBucket resource tests Test coverage and test infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanu-14 @alphacrack